Re-measure the branch conventions on 2.1.0 - #915
Merged
Merged
Conversation
Section 6 said the table was measured on a 2.0.0 build, which was true and is now also incomplete: 2.1.0 changes logarithm behaviour (#902 guards the exponent pull) and abs (#881), so a reader is entitled to ask whether the branch choices moved with them. All nine values are unchanged -- sqrt(-4), (-1)^(1/2), ln(-1), i^i, and the five negative-base powers including the (-8)^(1/3) against (-8)^0.3333333333 trap. Re-measuring these whenever a release touches a branch is the point of the section, so the sentence now says that rather than naming one build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplificationContract.md§6 said its table of branch choices was "measured on a 2.0.0 build". True, and now incomplete: 2.1.0 changes logarithm behaviour (#902 guards the exponent pull) andabs(#881), so a reader is entitled to ask whether the branch choices moved with them.All nine are unchanged, measured on a 2.1.0 build:
sqrt(-4)is2i,(-1)^(1/2)isi,ln(-1)ispi*i,i^iis0.2078..., and the five negative-base powers including the trap the section exists for —(-8)^(1/3)is-2while(-8)^0.3333333333is1 + 1.732i.The sentence now says to re-measure whenever a release touches a branch, rather than naming one build, since that is what the section is for.
Doc only.