Add a pull request template #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
So far as making this a checklist, I wonder if we can change the link to the contributing guide into a comment of some sort so it doesn't appear in the PR text? The only reason I say that is it might be good to reserve the checklist for something more actionable? Specifically, we can have checklist items can summarize some key points from the contributing guide. E.g. notebook matches x template; keywords are from y list, e.g.). |
eblur
reviewed
Jan 20, 2022
Contributor
eblur
left a comment
eblur
left a comment
There was a problem hiding this comment.
I have inserted my suggested wording for the check boxes.
kelle
requested changes
Jan 20, 2022
Co-authored-by: Lia Corrales <lia.astro@gmail.com> Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a short checklist that asks contributors to check the contributing guide or acknowledge they are aware of the procedure, and asks for acknowledging the code of conduct.
Thoughts for other things to include here?