Skip to content

update for FITS-images #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonathansick merged 6 commits into from
Jun 15, 2022
Merged

update for FITS-images #558

jonathansick merged 6 commits into from
Jun 15, 2022

Conversation

@HarrisChenchen
Copy link
Contributor

@HarrisChenchen HarrisChenchen commented May 27, 2022 •
edited
Loading

  • Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
  • Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
  • Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.

@review-notebook-app
Copy link

review-notebook-app bot commented May 27, 2022

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@eblur eblur requested a review from mwcraig June 8, 2022 18:09
mwcraig
mwcraig reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋 @HarrisChenchen! Thanks for this pull request -- this tutorial has needed some revision for a while. I have a few minor suggestions.

eblur and others added 3 commits June 10, 2022 13:48
@eblur @mwcraig
Update tutorials/FITS-images/FITS-images.ipynb
0b01bb0 
fix quotes

Co-authored-by: Matt Craig <mattwcraig@gmail.com>
@HarrisChenchen @mwcraig
Update tutorials/FITS-images/FITS-images.ipynb
0adec8d 
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
@HarrisChenchen @mwcraig
Update tutorials/FITS-images/FITS-images.ipynb
fd87b0e 
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
mwcraig
mwcraig reviewed Jun 11, 2022
View reviewed changes
@eblur @mwcraig
Apply suggestions from code review
015bbf1 
Co-authored-by: Matt Craig <mattwcraig@gmail.com>
@jonathansick jonathansick merged commit c9b9195 into astropy-learn:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mwcraig mwcraig mwcraig left review comments

@eblur eblur eblur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HarrisChenchen @mwcraig @eblur @jonathansick