Skip to content

Docs for arithmetic between magnitude systems#13823

Closed
PASEA-PG wants to merge 1 commit intoastropy:mainfrom
PASEA-PG:units_mag_docs
Closed

Docs for arithmetic between magnitude systems#13823
PASEA-PG wants to merge 1 commit intoastropy:mainfrom
PASEA-PG:units_mag_docs

Conversation

@PASEA-PG
Copy link

@PASEA-PG PASEA-PG commented Oct 11, 2022

Description

This pull request is to add documentation to show how magnitude systems can be compared. This PR is work in progress.

Fixes #13248

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@github-actions github-actions bot added the units label Oct 11, 2022
@pllim pllim added this to the v5.2 milestone Oct 11, 2022
@pllim pllim marked this pull request as draft October 11, 2022 15:58
@pllim
Copy link
Member

pllim commented Oct 11, 2022

Hello! Since you said it is a work in progress, I have turned this PR to draft for now. Please take it out of draft when you are ready for review. Thanks!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Astropy 👋 and congratulations on your first pull request! 🎉

A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code and make sure you've addressed as many of the questions there as possible.

If you feel that this pull request has not been responded to in a timely manner, please leave a comment mentioning our software support engineer @embray, or send a message directly to the development mailing list. If the issue is urgent or sensitive in nature (e.g., a security vulnerability) please send an e-mail directly to the private e-mail feedback@astropy.org.

@astrofrog astrofrog modified the milestones: v5.2, v5.3 Dec 8, 2022
@github-actions github-actions bot added the Close? Tell stale bot that this issue/PR is stale label Mar 11, 2023
@github-actions
Copy link
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@github-actions
Copy link
Contributor

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

@github-actions github-actions bot added the closed-by-bot Closed by stale bot label Apr 11, 2023
@github-actions github-actions bot closed this Apr 11, 2023
@pllim
Copy link
Member

pllim commented Apr 11, 2023

I thought more docs would come but they never did. I pinged @aaryapatil for clarification.

@aaryapatil
Copy link
Member

Thanks for the ping @pllim. Sorry for the delay on my end. I have this on my calendar to get done this week or next.

@pllim
Copy link
Member

pllim commented Jun 16, 2023

@aaryapatil , any progress? Thanks!

@pllim
Copy link
Member

pllim commented Oct 16, 2023

@aaryapatil , any update on this? Thanks!

@aaryapatil
Copy link
Member

Sorry @pllim. Turns out the students don't have access to the PASEA-PG account (so the delay is on me, not the students!), and with my move across continents I have lost it as well. But I will really (really) get to this by the end of this year (once I am on track with the finance work I have pending...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Close? Tell stale bot that this issue/PR is stale closed-by-bot Closed by stale bot Docs no-changelog-entry-needed units

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we allow arithmetic between STmag and ABmag?

4 participants