TST: Bump OpenAstronomy workflow version#19488
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Huh... @Cadair , why does new version of OpenAstronomy choke on the coverage?
|
|
On v2.4.0 , I see |
5188af4 to
e637a94
Compare
|
I added a commit here to remove the specification of the xml coverage report from the tox.ini. I don't really know why we would need that there other than uploading to codecov, which we do inside the workflows. I suspect I've probably broken something else by doing this though lol (edit: yes it's broken the circleci stuff, before I fix it I want to make sure it's something we want to do) |
|
Thanks!
It was probably there before OpenAstronomy template was a thing. While I am okay with removing it here, how will leaving it in affect other packages in the same situation? Do they need to remove it or things break? Also won't hardcoding it upstream make it impossible for packages to specify their own coverage output format or filename and so on?
CircleCI looks green to me. What is broken? |
The codecov reporting.
We don't need to remove it, it's just redundant. It's only the |
I see. Is that easy to fix? What are our options now? Thanks! |
Description
This pull request is to address lagging version in OpenAstronomy workflow. Is dependabot broken? 🤯