Remove replace_ argument for files_filtered again#580
Merged
mwcraig merged 1 commit intoastropy:masterfrom Oct 31, 2017
MSeifert04:remove_replace_
Merged
Remove replace_ argument for files_filtered again#580mwcraig merged 1 commit intoastropy:masterfrom MSeifert04:remove_replace_
mwcraig merged 1 commit intoastropy:masterfrom
MSeifert04:remove_replace_
Conversation
Contributor
Author
Member
|
Any thoughts on this, @bsipocz? |
Member
|
Ideally we'd talk about this in the narrative documentation, but I think those need a much larger overhaul that makes sense as part of ccdproc 2.0, so I'm merging this as-is. |
This was referenced Nov 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
replace_argument was basically a good idea but as #559 and #557 show whitespaces are not the only problematic character.-is quite frequently used and sometimes even.. Other invalid characters for keyword arguments are quite rare.However it might be better to just document the workaround (passing in an unpacked dictionary) than actually inventing a functionality that tries to cover these cases in an easy to use way.
If we make
replace_a dictionary for characters to translate that will be very awkward to use (because you could end up inventing different placeholders for different characters) and when you're passing in a dictionary already one might as well pass in the dictionary containing the key-value pairs.Note that
replace_hasn't been released yet so this doesn't need a deprecation.