Skip to content

chore: improve eslint setup with sonarjs - #256

Merged
derberg merged 3 commits into
asyncapi:masterfrom
derberg:sonarcube-intro
Mar 23, 2020
Merged

chore: improve eslint setup with sonarjs#256
derberg merged 3 commits into
asyncapi:masterfrom
derberg:sonarcube-intro

Conversation

@derberg

@derberg derberg commented Mar 19, 2020

Copy link
Copy Markdown
Member

Description

  • Add eslint to dev dep and have npm script for it
  • Add eslint sonarjs plugin

Related issue(s)
See also #220

@derberg derberg mentioned this pull request Mar 19, 2020
fmvilas
fmvilas previously approved these changes Mar 19, 2020

@fmvilas fmvilas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment thread CONTRIBUTING.md Outdated
@derberg derberg changed the title chore: Improve eslint settup with sonarjs chore: improve eslint setup with sonarjs Mar 19, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg
derberg merged commit fc21f57 into asyncapi:master Mar 23, 2020
@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.34.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants