feat: support filters from external library - #298
Conversation
fmvilas
left a comment
There was a problem hiding this comment.
Left some suggestions. Great stuff!
|
@fmvilas your suggestions are in, thanks! I also removed one not needed function that was left from my development. What about the config? nothing agains? should I move other config values there with this PR or? |
|
@fmvilas forget my last question, I'm removing |
fmvilas
left a comment
There was a problem hiding this comment.
Looks great! Minor stuff 👍
Co-Authored-By: Fran Méndez <fmvilas@gmail.com>
Co-Authored-By: Fran Méndez <fmvilas@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
filtersthat accepts an array of libraries that you can additionally register as filters for your template.generator.jsis super overwhelming so using the opportunity that I worked on filters I moved them outHow to test:
./cli.js test/docs/streetlights.yml https://github.com/derberg/html-template/#use-filters-lib -o output --force-writeMigration Guide
Your templates will not work with the latest generator. In your template, in filter directory you need to refactor your functions to follow new structure or remove filters that are already extracted to https://github.com/asyncapi/generator-filters
and have this package in
package.jsondependenciesRelated issue(s)
Fixes #212