feat: file-templates as array in React render engine - #518
Conversation
jonaslagoni
left a comment
There was a problem hiding this comment.
Just some small comments. In hindsight, I should have added tests for the renderer when first integrating the feature. Gonna create a follow up issue about that.
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
@magicmatatjahu you have a problem with SonarCloud 😄 |
|
@magicmatatjahu will you also do a follow-up in the template for templates, to use this new way for file templates? |
|
@derberg Of course, I will, but I wanna wait for merge your PR to write tests for an array of Files - your PR has architecture for tests. |
|
@magicmatatjahu you have a little problem with checks 😄 |
|
@magicmatatjahu you need to increase timeouts in the test project tests to a larger number, these tests are really long-running :( |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Docs part:
React
The above way of rendering file templates works for both
nunjucksandreactrender engine, butreactalso has another, more generic way to render multiple files. It is enough to return an array ofFilecomponents in the rendering component. Check example:Related issue(s)
Part of asyncapi-archived-repos/generator-react-sdk#10