fix: allow unknown custom schema formats without validation errors - #1218
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Preserve unknown custom schema formats as-is when schemaFormat is a string, and reject non-string values instead of treating them as valid. Co-authored-by: Cursor <cursoragent@cursor.com>
AayushSaini101
requested review from
asyncapi-bot-eve,
magicmatatjahu and
princerajpoot20
as code owners
August 6, 2026 09:39
🦋 Changeset detectedLatest commit: 7dd5257 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }, | ||
| ] as SchemaValidateResult[]; | ||
| } | ||
| return []; |
Member
There was a problem hiding this comment.
how about if we emit an info/warning diagnostic like: "No schema parser registered for..."
Collaborator
Author
There was a problem hiding this comment.
Added warning and updated the flow thanks
Contributor
|
@asyncapi/microgrant_team |
Emit a warning diagnostic when no schema parser is registered, drop unreachable non-string guards, and cover the asyncapi#1066 components.schemas reproduction. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
/rtm |
|
github-project-automation
Bot
moved this from In Progress
to Completed
in Microgrant Program
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That rejected valid documents that use custom schema formats without a registered schema parser.
Changes
schemaFormatschemaFormatto be a string; reject non-string valuesapplication/octet-streamand Avro without a registered parserRelated issue
Closes #1066
Test plan
schemaFormat: "application/octet-stream"and confirm it succeedsschemaFormatand confirm noUnknown schema formatdiagnosticschemaFormatis rejected