refactor: simplify Makefile — dev/prod split, remove Tailscale sidecar - #28
Merged
Conversation
…scale sidecar - `make dev` (API :3101, Vite :5173) and `make prod` (:3100) run side by side - Removed Docker Tailscale sidecar — all devices already on tailnet - DEPLOY_HOST read from .env (per-machine, gitignored) - Vite proxy updated to dev port :3101 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nox-0x
approved these changes
Mar 14, 2026
nox-0x
left a comment
Collaborator
There was a problem hiding this comment.
Clean refactor — the dev/prod split is much clearer than MODE=x, port assignments make sense, and removing the Tailscale sidecar simplifies the whole lifecycle. One minor note: the .gitignore change updates the pattern to deploy/serve.json.deploy but nothing in the new Makefile creates that file (DEPLOY_HOST is read directly from .env), so the entry is vestigial — worth either removing it or updating the PR description. No blocking issues.
aterrylu
marked this pull request as ready for review
March 14, 2026 09:00
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make up MODE=xintomake dev/make prod— cleaner, no mode flag needed:3101+:5173, prod on:3100DEPLOY_HOSTfrom.env— per-machine config without extra filesChanges
Makefile— replacedup/downwithdev/prod/down, removed all Docker/Tailscale sidecar logicvite.config.ts— proxy target updated from:3000to:3101.gitignore— added.deploydeploy/— removeddocker-compose.ymlandserve.jsonTest plan
make devstarts API on 3101, Vite on 5173make prodstarts on 3100 without touching devmake downkills bothmake deploy DEPLOY_HOST=forgeworksDEPLOY_HOST=forgein.envworks withmake deploy🤖 Generated with Claude Code