Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Move towards more efficient DOM manipulation #900
I like your approach to updating the tests. If the test coverage was good previously, then this should be fine. There was quite a bit of logic for constructing the elements and I'd be lying if I looked at each line super closely, but from a few minutes of inspection it all seems reasonable. I say we move forward with this. Nice work!
We figured out that appveyor is failing because of an ambiguity in the sorting logic in https://github.com/atom/superstring/blob/master/src/core/text-buffer.cc#L525
If the scores are the same, the order is left up to the order the matches showed up in
The fix for this is unrelated to this PR, so I think this PR is ready to go.