#209 better drive switcher

[Polleps]

PR Checklist:

• Link to related issue closes Improved drive switcher #209
• Add changelog entry linking to issue
• Added tests (if needed)
• (If new feature) added in description / readme

TODO:

• WebSocket shows disconnected on full page reload (add a test for this)
• Maybe add the new button to the dropdown list?
• If the user is not signed in, they should be told that they should, because then they can save their drives! We need some sort of explanation on what a Drive is. This is also missing in the docs.
• The button consistency is off. The drive switcher button is round with a border, the SideBarItem buttons are rounded and filled with an overlay.
• The alignment of the rows is off. Top item has too much padding, text is not centrally aligned.

[joepio]

please rebase first on main, your PR contains many of the same changes

[joepio]

ok, good stuff! Switcher is definitely an improvement. But it's not done:

todo list moved to OP

[Polleps]

ok, good stuff! Switcher is definitely an improvement. But it's not done:

• WebSocket shows disconnected on full page reload (add a test for this)
• Some default drives (such as localhost) look a bit weird if they don't work. Perhaps we should hide these defaults if they are offline, or only show them if the user is in fact visiting from localhost (add a test for this)
• The order of the list changes, the current one is always at the top. I think the order needs to be stable.
• Maybe add the new button to the dropdown list?
• If the user is not signed in, they should be told that they should, because then they can save their drives!
• We need some sort of explanation on what a Drive is. This is also missing in the docs.
• The button consistency is off. The drive switcher button is round with a border, the SideBarItem buttons are rounded and filled with an overlay.
• The alignment of the rows is off. Top item has too much padding, text is not centrally aligned.

1. Strange, I did not notice this locally, will look into it.

2. Localhost is only visible in development, localhost:5137 is just the origin so it would not look weird in production. The only case where a drive would look weird (eg, a red url) would be when a user manually adds a broken drive or other resource to their agents drives property.

3. The order of the list changes because it is a history of drives with a max of 5 drives. Maybe this can be better indicated by using a clock icon instead of the checkbox.

4. I don't think making a new drive will be that common of a use-case to have a dedicated option in the dropdown.

5 & 6) Good point

7. Dammit forgot to fix it again 😅

8. Oops