Clip renaming behavior of "Crossfade Clips" Nyquist effect

[Paul-Licameli]

Bug description

Note, this is the only shipped Nyquist effect with "restoresplits" set to false (non-default)

Steps to reproduce

1. Record some sound
2. Split the clip, and name the left part "a" and the right "b"
3. Make selections around the split, with the left and right edges each variously within a clip, or snapped to the other end
4. Apply effect
5. Observe clip renaming

Expected behavior

I'm not sure how correct behavior should be defined in all cases, but perhaps, consistently, the name of the left clip should prevail always

Actual behavior

Resulting clip name is "a" if you snap the right edge only, or neither; "b" if you snap left only; and reverts to the track name when you snap both.

Audacity Version

current master / alpha / nightly build

Operating system

Windows, macOS, Linux

Additional context

No response

[petersampsonaudacity]

@Paul-Licameli wrote:

I'm not sure how correct behavior should be defined in all cases, but perhaps, consistently, the name of the left clip should prevail always

I am strongly minded to agree. That seems a good and consistent approach.

The Reference Manual has nothing to say regarding this - and the visual example that @LWinterberg provided was made before the fix was made to always show the clip name:
https://alphamanual.audacityteam.org/man/Crossfade_Clips

[petersampsonaudacity]

@Paul-Licameli wrote:

I'm not sure how correct behavior should be defined in all cases, but perhaps, consistently, the name of the left clip should prevail always

I am strongly minded to agree. That seems a good and consistent approach.

@Paul-Licameli - Particularly so because when you click on the clip boundary of two adjacent clips to join the clips, or if you select a bunch of clips and use Edit > Audio Clips > Join, then the merged clip takes the name of the leftmost clip.

---

The Reference Manual has nothing to say regarding this - and the visual example that @LWinterberg provided was made before the fix was made to always show the clip name: https://alphamanual.audacityteam.org/man/Crossfade_Clips

I have fixed up the reference Manual for this:
https://alphamanual.audacityteam.org/man/Crossfade_Clips#Examples