Add support for labels in the SubRip and WebVTT formats#394
Closed
Pokechu22 wants to merge 3 commits intoaudacity:masterfrom
Closed
Add support for labels in the SubRip and WebVTT formats#394Pokechu22 wants to merge 3 commits intoaudacity:masterfrom
Pokechu22 wants to merge 3 commits intoaudacity:masterfrom
Conversation
e736aa9 to
afccc6d
Compare
Contributor
Author
|
Rebased to fix conflicts with aa39f9a. It seems a bit odd to have both |
afccc6d to
002e193
Compare
002e193 to
14997c6
Compare
(without actually implementing any new ones in this commit)
14997c6 to
1d07987
Compare
Member
|
Hey, this is a feature I care about! I can't believe I missed this PR until now. @Pokechu22 Can you rebase this PR onto latest master? |
6 tasks
Member
|
an updated version got merged |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows exporting labels in the SubRip and WebVTT formats (and importing labels in SubRip format as well, but not WebVTT). This is a resubmission of #383 that has been cleaned up a ton. There's a wiki article on the use for this.
Improvements from before:
EXPERIMENTAL_SUBRIP_LABEL_FORMATS(and I've made sure that everything compiles with it enabled and with it disabled)wxDateTime, based on what @kempniu did in Add support for importing/exporting SubRip subtitles #170.LabelTrack::FormatForFileName) so only one place needs to be modified, instead of 4 locations in 2 files.There are a few known issues:
|based on MicroDVD, which I have no experience with.)1for each file, and theWEBVTTheader is repeated. Although both of those are fixable, WebVTT also requires that the start time "must be greater than or equal to the start time offsets of all previous cues in the file" (§4.1, "WebVTT cue timings"). Resolving that requires merging the two files in sorted order and that would require a more substantial rework of how label track I/O works (which would be good eventually, as the labels editor would also be sorted by timestamp instead of track and then timestamp).