feat: each iterator can report its types on either end now #2849

barakmich · 2026-01-23T22:15:53Z

Description

Testing

References

codecov · 2026-01-23T22:21:47Z

Codecov Report

❌ Patch coverage is 89.11917% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.43%. Comparing base (c89c449) to head (401e9a2).

Files with missing lines	Patch %	Lines
pkg/query/types.go	70.38%	7 Missing and 1 partial ⚠️
pkg/query/intersection.go	70.00%	4 Missing and 2 partials ⚠️
pkg/query/union.go	70.00%	4 Missing and 2 partials ⚠️
pkg/query/build_tree.go	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2849      +/-   ##
==========================================
+ Coverage   74.43%   74.43%   +0.01%     
==========================================
  Files         484      484              
  Lines       57444    57629     +185     
==========================================
+ Hits        42750    42889     +139     
- Misses      11701    11736      +35     
- Partials     2993     3004      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tstirrat15

See comments, otherwise LGTM

pkg/query/exclusion_test.go

pkg/query/fixed.go

pkg/query/fixed_test.go

tstirrat15 · 2026-01-23T22:45:08Z

pkg/query/intersection.go

+	// All subiterators should have the same resource type
+	return i.subIts[0].ResourceType()


Is this enforced somewhere, implicitly or explicitly?

pkg/query/intersection_test.go

pkg/query/types.go

tstirrat15 · 2026-01-23T22:48:33Z

pkg/query/types.go

+		return []ObjectType{}
+	}
+
+	seen := make(map[string]bool)


Could also use mapz.Set here as well

tstirrat15

See comments

pkg/query/alias.go

tstirrat15 · 2026-01-27T22:25:38Z

pkg/query/intersection.go

+	// Validate that all subiterators have the same resource type
+	for idx, subIt := range i.subIts[1:] {
+		subType, err := subIt.ResourceType()
+		if err != nil {
+			return ObjectType{}, err
+		}
+		if firstType != subType {
+			return ObjectType{}, spiceerrors.MustBugf("intersection resource type mismatch: subiterator 0 has type %s, subiterator %d has type %s",
+				firstType.String(), idx+1, subType.String())
+		}
+	}


Is this potentially expensive?

Not terribly, no.

pkg/query/types.go

pkg/query/union_test.go

pkg/query/alias.go

miparnisari · 2026-01-28T15:26:15Z

pkg/query/arrow.go

 }
+
+func (a *Arrow) ResourceType() (ObjectType, error) {
+	// Arrow's resources come from the left side


i don't yet understand the reasoning behind this (why left and not right?) i suppose it will become apparent in a follow up PR where we use these functions

but in any case i'd move this to be a proper godoc of the function

definition user {} definition group { relation member: user } definition document { relation group: group permission view = group->member }

for view, then, the document is clearly the type of the resource -- it's also the type of the resource for the group relation (so this is the left side). Then the right side is the right side of member, which is user

miparnisari · 2026-01-28T15:35:06Z

pkg/query/self.go

 var _ Iterator = &Self{}

-func NewSelf(relation string) *Self {
+func NewSelf(relation string, resourceType ObjectType) *Self {


i can't find a caller of this function where relation != resourceType.subrelation. Do you need that first parameter at all?

tstirrat15

barakmich requested a review from a team as a code owner January 23, 2026 22:15

github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 23, 2026

barakmich force-pushed the barakmich/types_1 branch from b2f95da to 956504b Compare January 23, 2026 22:18

tstirrat15 previously approved these changes Jan 23, 2026

View reviewed changes

barakmich mentioned this pull request Jan 24, 2026

feat: add type filtering to the query plan #2850

Merged

barakmich dismissed tstirrat15’s stale review via 6acb9e2 January 27, 2026 21:30

barakmich force-pushed the barakmich/types_1 branch from 6acb9e2 to 8394a1f Compare January 27, 2026 21:32

tstirrat15 previously approved these changes Jan 27, 2026

View reviewed changes

barakmich dismissed tstirrat15’s stale review via 6a11b47 January 27, 2026 22:43

barakmich force-pushed the barakmich/types_1 branch from 8394a1f to 6a11b47 Compare January 27, 2026 22:43

miparnisari reviewed Jan 28, 2026

View reviewed changes

pkg/query/types.go Outdated Show resolved Hide resolved

miparnisari reviewed Jan 28, 2026

View reviewed changes

pkg/query/union_test.go Outdated Show resolved Hide resolved

miparnisari reviewed Jan 28, 2026

View reviewed changes

pkg/query/alias.go Outdated Show resolved Hide resolved

miparnisari reviewed Jan 28, 2026

View reviewed changes

barakmich force-pushed the barakmich/types_1 branch from c734e0b to 5894c5e Compare January 28, 2026 21:30

barakmich added 4 commits January 28, 2026 14:52

feat: add type information methods and struct to the types

8a6fbb1

feat: implement type listing for every iterator

c8e013f

chore: update for comments

2b27e3c

chore: more comments

401e9a2

barakmich force-pushed the barakmich/types_1 branch from 5894c5e to 401e9a2 Compare January 28, 2026 22:52

barakmich enabled auto-merge January 28, 2026 23:19

tstirrat15 approved these changes Jan 28, 2026

View reviewed changes

barakmich added this pull request to the merge queue Jan 28, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026

barakmich added this pull request to the merge queue Jan 28, 2026

github-merge-queue bot pushed a commit that referenced this pull request Jan 28, 2026

feat: each iterator can report its types on either end now (#2849)

ceeef0f

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026

barakmich added this pull request to the merge queue Jan 28, 2026

Merged via the queue into main with commit d4b1b63 Jan 29, 2026
44 of 45 checks passed

barakmich deleted the barakmich/types_1 branch January 29, 2026 00:09

github-actions bot locked and limited conversation to collaborators Jan 29, 2026

		// All subiterators should have the same resource type
		return i.subIts[0].ResourceType()

feat: each iterator can report its types on either end now #2849

feat: each iterator can report its types on either end now #2849

Uh oh!

Conversation

barakmich commented Jan 23, 2026

Description

Testing

References

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tstirrat15 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tstirrat15 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tstirrat15 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

tstirrat15 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tstirrat15 Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

barakmich Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miparnisari Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barakmich Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

miparnisari Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

tstirrat15 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jan 23, 2026 •

edited

Loading

miparnisari Jan 28, 2026 •

edited

Loading