Skip to content

Conversation

@barakmich
Copy link
Contributor

Depends on #2849

Description

Testing

References

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 83.72093% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.43%. Comparing base (0ab9618) to head (967570a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/context.go 54.55% 8 Missing and 2 partials ⚠️
pkg/query/path.go 80.00% 6 Missing and 2 partials ⚠️
pkg/query/datastore.go 50.00% 1 Missing ⚠️
pkg/query/intersection_arrow.go 85.72% 1 Missing ⚠️
pkg/query/recursive_sentinel.go 50.00% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (74.43%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2850      +/-   ##
==========================================
- Coverage   74.44%   74.43%   -0.00%     
==========================================
  Files         484      484              
  Lines       57702    57764      +62     
==========================================
+ Hits        42948    42990      +42     
- Misses      11744    11761      +17     
- Partials     3010     3013       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@barakmich barakmich marked this pull request as ready for review January 29, 2026 00:12
@barakmich barakmich requested a review from a team as a code owner January 29, 2026 00:12
tstirrat15
tstirrat15 previously approved these changes Jan 29, 2026
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a comment but it's an understanding thing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a filter_test.go but not filter.go?

@barakmich barakmich enabled auto-merge (squash) January 30, 2026 19:26
@barakmich barakmich merged commit ce59421 into main Jan 30, 2026
76 of 78 checks passed
@barakmich barakmich deleted the barakmich/types_2 branch January 30, 2026 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants