-
Notifications
You must be signed in to change notification settings - Fork 366
feat: add type filtering to the query plan #2850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (74.43%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2850 +/- ##
==========================================
- Coverage 74.44% 74.43% -0.00%
==========================================
Files 484 484
Lines 57702 57764 +62
==========================================
+ Hits 42948 42990 +42
- Misses 11744 11761 +17
- Partials 3010 3013 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
36eee3d to
adb09fc
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, had a comment but it's an understanding thing
adb09fc to
1443b0b
Compare
1443b0b to
967570a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a filter_test.go but not filter.go?
Depends on #2849
Description
Testing
References