Set --no-cc-version-check flag to build on ubuntu 22.04 (#2389) #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gcc compiler used to build the kernel on Ubuntu 22.04 images we use is 11.3, but the gcc apt package seems to install 11.4 for use in the terminal. This flag will prevent the NVIDIA driver from failing to install due to the minor version difference in gcc.
Codecov Report
@@ Coverage Diff @@
## develop #2404 +/- ##
========================================
Coverage 70.34% 70.34%
========================================
Files 13 13
Lines 1851 1851
========================================
Hits 1302 1302
Misses 549 549
Flags with carried forward coverage won't be shown. Click here to find out more. |
enrico-usai
approved these changes
Aug 7, 2023
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
to gmarciani/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 17, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (aws#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel aws#2852.
gmarciani
added a commit
that referenced
this pull request
Feb 19, 2025
…ver. We remove it because: 1/ it is not supported anymore by the NVIDIA installer. 2/ it was an unsafe workaround introduced in 3.8.0 (#2404), which was supposed to be there only in the short term and in ended be there for long time. 3/ we introduced in 3.12.0 a logic to install NVIDIA drivers using the gcc version used to compile the kernel #2852.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gcc compiler used to build the kernel on Ubuntu 22.04 images we use is 11.3, but the gcc apt package seems to install 11.4 for use in the terminal. This flag will prevent the NVIDIA driver from failing to install due to the minor version difference in gcc.
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.