Apply missing patches from (the now unused) internal repo #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterwerlla
changed the title
hunterwerlla
force-pushed
the
hunterwerlla/apply-missing-patches
branch
from
15999d2 to
341c51c
Compare
mpiroc
previously requested changes
May 6, 2019
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Show resolved
Hide resolved
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Show resolved
Hide resolved
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Show resolved
Hide resolved
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Show resolved
Hide resolved
Tasks/CloudFormationCreateOrUpdateStack/helpers/CreateOrUpdateStackTaskParameters.ts
Show resolved
Hide resolved
Tasks/CloudFormationCreateOrUpdateStack/helpers/CreateOrUpdateStackTaskParameters.ts
Show resolved
Hide resolved
Tasks/CloudFormationCreateOrUpdateStack/helpers/CreateOrUpdateStackTaskParameters.ts
Show resolved
Hide resolved
Tasks/CloudFormationExecuteChangeSet/helpers/ExecuteChangeSetTaskParameters.ts
Show resolved
Hide resolved
hunterwerlla
force-pushed
the
hunterwerlla/apply-missing-patches
branch
from
341c51c to
53cc4fc
Compare
awschristou
suggested changes
May 8, 2019
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Outdated
Show resolved
Hide resolved
Tasks/BeanstalkDeployApplication/helpers/DeployApplicationTaskOperations.ts
Outdated
Show resolved
Hide resolved
hunterwerlla
force-pushed
the
hunterwerlla/apply-missing-patches
branch
from
c4ebadb to
0c43fc3
Compare
… to use previous template when updating stack.
…d prior to use if needed.
hunterwerlla
force-pushed
the
hunterwerlla/apply-missing-patches
branch
from
0c43fc3 to
b94f9ca
Compare
hunterwerlla
force-pushed
the
hunterwerlla/apply-missing-patches
branch
from
b94f9ca to
5a501f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
- Coverage 55.02% 53.75% -1.28%
==========================================
Files 3 3
Lines 169 173 +4
Branches 25 27 +2
==========================================
Hits 93 93
- Misses 76 80 +4
Continue to review full report at Codecov.
|
Merged
9 tasks
awschristou
approved these changes
May 13, 2019
hunterwerlla
added a commit
that referenced
this pull request
May 14, 2019
… into their own file (#177) - Make awsConnectionParameters.ts into it's own file, working closer towards #166 . - AWSTasksParametersBase contains a ton of functions that are not actually member functions, this creates the AwsConnectionParameters interface for those items - Refactor S3Upload to be testable - Add functional tests for S3 Upload - Refactor S3 Upload to also use aws ConnectionParameters - Take changes from issue #114 out of #156 and put them in this PR as the whole module is refactored - Split out an S3 utility function used by both upload and download into its own file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#126, #124, #123, #106, #127
Description of changes:
Pull in the existing patches that are already completed but not part of this repo. From now on, this will be the only repo for this project.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.