-
Notifications
You must be signed in to change notification settings - Fork 48
Implement H2 decoder #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement H2 decoder #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement new H2 decoder vtable * Implement the H2 decoder state machine * NOTE: Header blocks are not implemented yet, and as such the HEADERS, CONTINUATION, and PUSH_PROMISE frames are incomplete
1635c7a to
2e39db4
Compare
JonathanHenson
approved these changes
Oct 22, 2019
JonathanHenson
suggested changes
Oct 22, 2019
Contributor
JonathanHenson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Premature approve
graebm
reviewed
Oct 22, 2019
c0c8cab to
dd60152
Compare
cc41fe8 to
3406a57
Compare
graebm
reviewed
Oct 23, 2019
0f25829 to
6d866e7
Compare
6d866e7 to
e091a50
Compare
justinboswell
approved these changes
Oct 24, 2019
graebm
approved these changes
Oct 24, 2019
Contributor
graebm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does these and ship it
28cfe78 to
5f0676a
Compare
JonathanHenson
approved these changes
Oct 24, 2019
5f0676a to
0fbe40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.