Skip to content

Implement H2 decoder #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 24, 2019
Merged

Implement H2 decoder #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2e39db4
Implement H2 decoder
dislogical Oct 22, 2019
a90345e
Make global states const
dislogical Oct 22, 2019
e2549f0
f_ -> frame_
dislogical Oct 22, 2019
0892523
Appease the MSVC type conversion gods
dislogical Oct 22, 2019
d50fc4a
Henso PR feedback
dislogical Oct 22, 2019
5060c22
CI Fixes
dislogical Oct 22, 2019
d79c927
Split goaway into 2 states
dislogical Oct 23, 2019
01f7603
Improve error handling and end of state detection
dislogical Oct 23, 2019
7a88665
Handle leftover scratch into streaming state case
dislogical Oct 23, 2019
8d3a0f6
Handle custom frames
dislogical Oct 23, 2019
dd60152
Misc. PR feedback
dislogical Oct 23, 2019
3406a57
uint32_t pass
dislogical Oct 23, 2019
3f89178
Add error handling strategy (don't) to the decoder
dislogical Oct 23, 2019
e091a50
More PR feedback
dislogical Oct 23, 2019
0fbe40d
Decrement payload_len in unknown frame state
dislogical Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/aws/http/http.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ enum aws_http_errors {
AWS_ERROR_HTTP_CONNECTION_MANAGER_SHUTTING_DOWN,
AWS_ERROR_HTTP_PROTOCOL_ERROR,
AWS_ERROR_HTTP_STREAM_CLOSED,
AWS_ERROR_HTTP_INVALID_FRAME_SIZE,

AWS_ERROR_HTTP_END_RANGE = 0x0C00,
};
Expand Down
19 changes: 18 additions & 1 deletion include/aws/http/private/h2_decoder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,30 @@

#include <aws/http/private/http_impl.h>

struct aws_h2_decoder_vtable {

int (*on_headers)(uint32_t stream_id, void *userdata);
int (*on_end_headers)(uint32_t stream_id, void *userdata);

int (*on_data)(uint32_t stream_id, const struct aws_byte_cursor *data, void *userdata);

int (*on_rst_stream)(uint32_t stream_id, uint32_t error_code, void *userdata);

int (*on_ping)(bool ack, uint8_t opaque_data[8], void *userdata);
int (*on_setting)(uint16_t setting, uint32_t value, void *userdata);
int (*on_settings_ack)(void *userdata);
int (*on_goaway)(uint32_t last_stream, uint32_t error_code, uint32_t debug_data_length, void *userdata);
int (*on_goaway_debug_data)(const struct aws_byte_cursor *data, void *userdata);
};

/**
* Structure used to initialize an `aws_h2_decoder`.
*/
struct aws_h2_decoder_params {
struct aws_allocator *alloc;
void *user_data;
struct aws_http_decoder_vtable vtable;
struct aws_h2_decoder_vtable vtable;
void *userdata;
};

struct aws_h2_decoder;
Expand Down
8 changes: 2 additions & 6 deletions source/h2_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,8 @@ static struct aws_http_connection_vtable s_h2_connection_vtable = {
.update_window = NULL,
};

static const struct aws_http_decoder_vtable s_h2_decoder_vtable = {
.on_request = NULL,
.on_response = NULL,
.on_header = NULL,
.on_body = NULL,
.on_done = NULL,
static const struct aws_h2_decoder_vtable s_h2_decoder_vtable = {
.on_data = NULL,
};

/* Common new() logic for server & client */
Expand Down
Loading