Fixing monitoring options being passed onto connection when invalid #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rccarper
force-pushed
the
connection_manager_fix
branch
from
4c5ab29 to
e8ed5fe
Compare
bretambrose
approved these changes
Feb 7, 2020
rccarper
force-pushed
the
connection_manager_fix
branch
from
e8ed5fe to
3011c67
Compare
justinboswell
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not set, connection manager monitoring options are intentionally invalid, but can then currently be passed onto connections, which can break them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.