Skip to content

Fixing monitoring options being passed onto connection when invalid #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Fixing monitoring options being passed onto connection when invalid #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3011c67
Fixing monitoring options being passed onto connection when invalid
rccarper Feb 7, 2020
925d806
Merge branch 'master' into connection_manager_fix
Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion source/connection_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,10 @@ static int s_aws_http_connection_manager_new_connection(struct aws_http_connecti
options.socket_options = &manager->socket_options;
options.on_setup = s_aws_http_connection_manager_on_connection_setup;
options.on_shutdown = s_aws_http_connection_manager_on_connection_shutdown;
options.monitoring_options = &manager->monitoring_options;

if (aws_http_connection_monitoring_options_is_valid(&manager->monitoring_options)) {
options.monitoring_options = &manager->monitoring_options;
}

struct aws_http_proxy_options proxy_options;
AWS_ZERO_STRUCT(proxy_options);
Expand Down