Running tests for arm CI#792
Merged
Merged
Conversation
waahm7
approved these changes
Jun 12, 2024
| "architectures": { | ||
| "armv7": { | ||
| "_comment": [ | ||
| "Due to inability to differentiate at runtime armv6 vs armv7 in the jvm", |
Contributor
There was a problem hiding this comment.
A comment about why we can't differentiate at runtime would be greatly appreciated.
Contributor
Author
There was a problem hiding this comment.
well, I also don't know... Just copy/paste from the comments in our CI before.
waahm7
reviewed
Jun 12, 2024
Co-authored-by: Waqar Ahmed Khan <waahm7@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
multiarch/qemu-user-staticdoes not support arm host properly, here is my attempt to use https://github.com/dbhi/qus for arm host, which works, but we suffer from the docker pull limits, and no needs as we are not using arm host now.TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.