Skip to content

Running tests for arm CI#792

Merged
TingDaoK merged 48 commits into
mainfrom
test-ci-delete-me
Jun 13, 2024
Merged

Running tests for arm CI#792
TingDaoK merged 48 commits into
mainfrom
test-ci-delete-me

Conversation

@TingDaoK

@TingDaoK TingDaoK commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

Issue #, if available:

  • The arm build was not running tests as expected

Description of changes:

TODO:

  • We should probably move the armv7 test separately as an integration test. Not running those for each commit pushed.
  • github runner for ARM is coming soon, https://github.com/orgs/community/discussions/73040, which may also have the same issue that for armv7, we still need qemu to run, but may work better in term of missing log or the docker pull limits?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK marked this pull request as ready for review June 11, 2024 17:24
@TingDaoK TingDaoK changed the title Use codebuild arm runner for arm CI Running tests for arm CI Jun 11, 2024

@waahm7 waahm7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

Comment thread .github/workflows/ci.yml Outdated
Comment thread builder.json
"architectures": {
"armv7": {
"_comment": [
"Due to inability to differentiate at runtime armv6 vs armv7 in the jvm",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about why we can't differentiate at runtime would be greatly appreciated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I also don't know... Just copy/paste from the comments in our CI before.

Comment thread builder.json Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Waqar Ahmed Khan <waahm7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants