Implements #27: Add lexer/syntax highlighting. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
This block is straight from prompt_toolkit==0.52.
Contributor
Author
|
I'll check out the tests.
I have to remember to remove my local |
load_completions calls load_index, which can throw IndexLoadError if the index file doesn't exist. load_completions now simply does nothing if the index file does not exist, resulting in no change to the attributes commands, subcommands, global_opts, and args_opts, each of which is a collection of strings. If no completions exist because there's no index, it seems reasonable to return no completions. Not throwing an exception with load_completions also simplifies integration tests.
CompletionIndex was recently refactored locally (prior to the initial commit for the lexer feature) to use attributes for commands, subcommands, args_opts, global_opts rather than returning the equivalent 4 element tuple in load_completions. This change updates the tests accordingly.
Moving this out is more modular, as CompletionIndex() is created in two places in the source: main and lexer (possible refactor TODO item). It's also called once in the tests. This change also simplifies testing as we can more easily substitute a mock function, although this could also probably be achieved with a mock side effect.
Contributor
Author
|
Follow-ups pass ci, should be ready for review. |
Member
|
|
I've been trying this out locally. Looks great!
donnemartin
added a commit
that referenced
this pull request
Dec 24, 2015
Implements #27: Add lexer/syntax highlighting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #27 with the following proposal:
A lexer would make it easier to visually distinguish the different components of a command:
Config File
Default theme: vim
Disable Syntax Highlighting
Sample: Dark Background
Samples: Light Background
Note: My terminal colors are customized which might be why we see light gray for
aws>.