fix: thread turn-timeout-ms into adversarial-review's app-server turn - #39
Closed
axisrow wants to merge 1 commit into
Closed
fix: thread turn-timeout-ms into adversarial-review's app-server turn#39axisrow wants to merge 1 commit into
axisrow wants to merge 1 commit into
Conversation
…closes #38) The adversarial-review branch of executeReviewRun called runAppServerTurn without turnTimeoutMs, even though the native review branch and the task branch both pass it through. --turn-timeout-ms was silently ignored for adversarial-review, so a stalled turn fell back to the library's 600s default instead of the requested budget. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BuAt7yyXHmZPpKFTJTkpdP
Owner
Author
🔍 Local review (cycle 1)Reviewed locally (
Totals: 0 FIX, 0 SKIP, 0 UNVERIFIED. Clean review — no blocking issues. |
Owner
Author
📋 Review summary — all cycles
Totals: 0 FIX, 0 SKIP, 0 UNVERIFIED. Clean on the first cycle — no cleanup pass needed. Review mode: local. This PR was not merged automatically (local mode is review-only on merge) — merge is yours to trigger when ready. |
This was referenced Aug 1, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #38.
executeReviewRun's adversarial-review branch calledrunAppServerTurnwithoutturnTimeoutMs, even though the nativereviewbranch (runAppServerReview) and thetaskbranch both pass it through. As a result,--turn-timeout-mswas silently ignored foradversarial-review— a stalled turn fell back to the library's 600sDEFAULT_TURN_TIMEOUT_MSinstead of the caller's requested budget.The fix is a one-line addition of
turnTimeoutMs: request.turnTimeoutMsalongside the existingeffort/sandboxoptions in that call (plugins/codex/scripts/codex-companion.mjs).Context
Same investigation that turned up this bug also looked at the env-var-based turn-budget approach landing upstream in openai#376. That PR's asymmetry doesn't reproduce here — there the budget is threaded via an env mutation that both branches pick up implicitly. This bug is fork-specific: a side effect of this fork's move to options-threading in fork PR #28 (
fix: turn-timeout gaps), where the native-review and task call sites were updated but the adversarial-review call site was missed.No version bump — 1.0.6-fork.6 was just released; this isn't a release PR.
Test plan
tests/runtime.test.mjs):adversarial-review with stalled turn/start honors --turn-timeout-ms instead of the library default, modeled on the existingtask with stalled turn/start times out via --turn-timeout-ms instead of hanging forevertest. Confirmed it hung toward the 600s library default before the fix.npm test: 175/178 pass. The 3 failures are pre-existing state-dir/job-listing flakes unrelated to this change (same failures reproduce onfork/mainbefore this commit).npm run build: passes (tsc -p tsconfig.app-server.json), no new TS errors.🤖 Generated with Claude Code
https://claude.ai/code/session_01BuAt7yyXHmZPpKFTJTkpdP