fix: forward turnTimeoutMs to adversarial-review's runAppServerTurn call - #44
Merged
Merged
Conversation
adversarial-review parses --turn-timeout-ms but never applied it, so long reviews silently fell back to the library's 600000ms default instead of the requested budget (or the 110000ms foreground default). The native review path and task path already forwarded turnTimeoutMs correctly; only the adversarial branch's runAppServerTurn call dropped it. Closes #38 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adversarial-reviewparsed--turn-timeout-msbut never forwarded it to the underlyingrunAppServerTurncall, so long reviews silently fell back to the library's 600000ms default (nativereviewandtaskalready forwarded it correctly).turnTimeoutMs: request.turnTimeoutMsfield to the adversarial branch'srunAppServerTurncall inexecuteReviewRun.Closes #38
Test plan
tests/runtime.test.mjs) using the existingstalled-turn-startfixture and a 3s--turn-timeout-msbudget; confirmed it genuinely reproduces the bug pre-fix (measured ~602.5s hang against the 600000ms default before the fix, ~5.6s after).npm test— full suite passes except 3 pre-existing failures unrelated to this change (verified viagit stashthat they fail identically onmain).npm run build— TS build gate passes.