Adapt /analyze embed aspect ratio to source orientation#43
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
polter-dev
marked this pull request as ready for review
July 12, 2026 01:05
polter-dev
added a commit
that referenced
this pull request
Jul 12, 2026
polter-dev
added a commit
that referenced
this pull request
Jul 12, 2026
# Conflicts: # src/components/capcheck-app.test.tsx # src/components/scorecard.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
.video-facadealways usedaspect-ratio: 9 / 16, so long-form landscape videos were forced into a tall portrait rail.TDD evidence
npx vitest run src/lib/source-orientation.test.tsinitially failed because the helper did not exist.landscapebefore their recognizers were added.data-orientationattribute before the facade wiring was implemented.watch?v=,youtu.be, YouTube embed, an unknown domain, and an upload.data-orientation="vertical"at a computed 9:16 ratio on desktop and mobile.Local gate
npm run lint— passednpm run typecheck— passednpm run test:unit— 224 passed, 5 skippednpm run build— passednpm run test:e2e— 33 passed, 1 skippedAll shared fixture
source.urlvalues are YouTube Shorts URLs, so fixture results remain vertical and visually unchanged. The landscape path is covered by unit/component tests and applies to real long-form and unknown URLs; shared fixtures were not modified.Agent handoff
fix/analyze-embed-aspectcca2e3ac4891491172015d3f290eefc3f3732df0polter-dev <144177408+polter-dev@users.noreply.github.com>CAPCHECK_ANALYSIS_MODE=fixture npm run devstarted successfully. The interactive browser backend was unavailable for a manual visual session, so the existing no-runtime-errors Playwright check plus a new rendered 9:16 fixture assertion provide the browser sanity evidence.