Logo, favicon, and /analyze header polish#44
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
polter-dev
marked this pull request as ready for review
July 12, 2026 01:12
polter-dev
added a commit
that referenced
this pull request
Jul 12, 2026
# Conflicts: # src/components/capcheck-app.test.tsx # src/components/scorecard.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icon.pngconventionSiteHeader/analyzewhile preserving the results mini-intakeTest updates
The analyzer assertions now target the global
SiteHeaderand no longer expect the removed cosmetic tagline. Component coverage explicitly verifies that the duplicate headers are absent and that the results mini-intake remains accessible. Feed/analyzer Playwright coverage verifies the shared logo and generated favicon metadata across desktop and mobile.TDD red evidence: the focused component run initially failed because the old landing/results identity blocks and solid-square site mark were still rendered.
Shared surface heads-up
This changes the shared
SiteHeadermark used by Feed, Analyze, and feed detail. Feed coverage was updated and remains green; the feed owner should get a heads-up.Stack
This PR targets
mainand stacks on the analyze embed-aspect work in #43. The embed-aspect logic is unchanged here.Verification
npm run lintnpm run typechecknpm run test:unit— 225 passed, 5 skippednpm run buildnpm run test:e2e— 33 passed, 1 expected skipThe in-app manual browser backend was unavailable in this environment; route/logo/favicon and runtime-console coverage was verified through the fixture-backed Playwright suite.