Skip to content

added styles for user - #1529

Merged
hzoo merged 2 commits into
babel:docusaurusfrom
ajaymathur:users-page
Jan 28, 2018
Merged

added styles for user#1529
hzoo merged 2 commits into
babel:docusaurusfrom
ajaymathur:users-page

Conversation

@ajaymathur

@ajaymathur ajaymathur commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

updated the users styles. #1528

Addition:

added a hover effect, please drop review for that too. Also let me know if needs to reverted. 🙂

@babel-bot

babel-bot commented Jan 27, 2018

Copy link
Copy Markdown
Contributor

Deploy preview for babel ready!

Built with commit b23f888

https://deploy-preview-1529--babel.netlify.com

@@ -0,0 +1,52 @@
.mainContainer .showcaseSection .logos {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be nested like this?

@ajaymathur ajaymathur Jan 28, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove mainContainer but I think we should keep .showcaseSection .logos so that styles don't effect other pages.

@hzoo

hzoo commented Jan 28, 2018

Copy link
Copy Markdown
Member

I'll land as is and you/someone can make another pr

@hzoo
hzoo merged commit 20f2516 into babel:docusaurus Jan 28, 2018
This was referenced Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants