Initial Docusaurus rewrite by hzoo · Pull Request #1521 · babel/website

hzoo · 2018-01-24T23:31:28Z

preview: https://deploy-preview-1521--babel.netlify.com/

Shouldn't look at the diff since there's too many files changed, looking for more PRs against it

cd website && yarn && yarn start

priority/easy

search works
blog works: had to change author_url to authorURL and  comments
links need highlights/underline (I like how https://reactjs.org/ has it)
make a subdomain and deploy for old website (branch is old-site, url is https://old.babeljs.io/)
create a UI somewhere linking to the old site if someone really needs it, or for our own reference Add link to old site, redirect env #1537
main docs - need to redo how readme's are rendered {% include package_readme.html %} [@existentialism is working on this right now]
- link to npm/github/edit
versioning of v6 and v7 [@existentialism is working on this right now] Support switching between v6 and v7 docs #1261
handle redirects (https://github.com/babel/website/blob/master/_redirects) New Site: redirects #1535
in <head>: should we keep things from https://github.com/babel/website/blob/master/_includes/head.html?

special pages

babel-bot · 2018-01-24T23:35:05Z

Deploy preview for babel ready!

Built with commit 587b885

https://deploy-preview-1521--babel.netlify.com

xtuc · 2018-01-25T09:07:58Z

That is looking nice!

Should we keep our old design or change it by the way?

hzoo · 2018-01-25T15:15:49Z

I don't think we should go out of our way to keep it so maybe both 😛 - vuejs.org, https://reactjs.org/, https://deploy-preview-3718--prettier.netlify.com/ look pretty nice @azz if you have ideas

I guess we just need to get the content (docs) back in working order and just continue to iterate otherwise it will take forever for this to happen and we need it asap for the content not to make it look nice.

JoelMarcey · 2018-01-25T15:25:05Z

@hzoo Hi! Thanks for giving Docusaurus a go. Let us know if you have any questions as you work through the conversion. You can jump into our Discord channel, file an issue on the Docusaurus repo, or just comment here.

cc: @ericnakagawa

Daniel15

Anything particularly important to review in this diff? There's a lot of files :P

Daniel15 · 2018-01-25T17:46:29Z

 - name: npm
  url: https://www.npmjs.com
  logo: npm.svg
+  pinned: true


Is this change related? If not, could you submit it as a separate PR?

hzoo · 2018-01-25T17:48:23Z

Sorry it I didn't mean to ask to review the code perse since at the top I said it would be impossible to do in a PR. It was more about feedback on the UI and the other things - or if there is something not covered in my bullet points that you are aware of.

Or maybe related to deployment/versioning/redirects

Daniel15 · 2018-01-25T17:52:14Z

oh, lol, I'm not sure how I missed that.

This page doesn't work properly (has some markup showing): https://deploy-preview-1521--babel.netlify.com/docs/en/setup.html

One thing we should ensure is kept is URLs. For example, https://deploy-preview-1521--babel.netlify.com/docs/usage/caveats/ throws a 404 because the URL has changed to https://deploy-preview-1521--babel.netlify.com/docs/en/caveats.html.

If it's impossible to keep exactly the same URLs, then the old URLs should 301 (permanent) redirect to new ones. You can do this with Netlify by using a _redirects file: https://www.netlify.com/docs/redirects/. For the language-based pages in particular, Netlify supports language- and location-based redirects. For example, /docs/usage/caveats could redirect to /docs/en/caveats.html if the browser's language is set to English, /docs/it/caveats.html if it's set to Italian, etc. Each redirect needs to be specified in the _redirects file (one line per page per supported language).

hzoo · 2018-01-25T17:54:12Z

@Daniel15 yeah i'm tracking the pages that don't work in the ^ but I didn't do a good job of explaining haha (setup is one of them)

yeah exactly we want to keep old urls and redirect 👍 👍

hzoo · 2018-01-25T19:24:16Z

Ok made a new site on netlify so we can make a new branch to target for the old site: old-site and a new subdomain: https://old.babeljs.io for previous stuff

GregBorrelly · 2018-01-26T19:48:41Z

Hey guys, are there any tasks I can take over? I would love to participate.

SavePointSam · 2018-01-26T20:56:19Z

Same here! I'd love to tackle some thing/s this weekend :D

* feat(videos): convert the videos page into react component * update: change video.css * update: rm old videos file * fix: add @media screen into video.css

hzoo · 2018-01-26T23:11:14Z

Yeah @GregBorrelly, @SavePointSam, and anyone else looking - I already made a few issues tagged in this PR that people can do as separate tasks. It's mostly making sure that we can bring back functionality from the current site (babeljs.io) into this one (check the preview url), so anything you can do for that would be appreciated since it all adds up. Sometimes it's worth rewriting too if you feel inspired too.

* added styles for user * added browser hack for transform

* Add repl to new site * Tweak styles * Remove old things * height: 100% fallback

* team page added.(#1523) * custom page team added to header links * unique key prop warning fixed.unwanted variable removed * code refactoring, composed jsx elements into functional comps * responsive design bug fixed * container left,right padding removed for more usage of space * common styles from video.css & team.css -> babel.css

* removed maincontainer from css style where it could be removed for users page * updated styles?

hzoo · 2018-01-30T20:45:17Z

Will make a new issue #1485 (comment)

hzoo added 3 commits January 24, 2018 17:13

initial commit for docusaurus

3774ba0

add readme, fix image

cd98391

add search and other links

c949028

hzoo force-pushed the docusaurus branch from 40ff8c8 to f2395cd Compare January 24, 2018 23:35

test deploy

c3104a2

hzoo force-pushed the docusaurus branch from f2395cd to c3104a2 Compare January 24, 2018 23:43

remove old stuff

bdeeceb

existentialism added 3 commits January 25, 2018 10:08

Add prettier

f21ded1

Disable header title

19d2d82

Add some initial blog styles

11087e9

hzoo requested review from Daniel15, azz and bvaughn January 25, 2018 17:14

Tweak more blog styles

f1ca2c2

Daniel15 reviewed Jan 25, 2018

View reviewed changes

remove old styles and data

bb04099

This was referenced Jan 26, 2018

New Site: Videos page #1522

Closed

New Site: REPL page #1525

Closed

hzoo added the new site any issues for the new site using docusaurus label Jan 26, 2018

hzoo mentioned this pull request Jan 26, 2018

New Site: 404 page #1526

Closed

remove unused files

bb26841

hzoo mentioned this pull request Jan 26, 2018

New Site: Users page #1528

Closed

feat(videos): convert the videos page into react component (#1524)

668ea89

* feat(videos): convert the videos page into react component * update: change video.css * update: rm old videos file * fix: add @media screen into video.css

SavePointSam mentioned this pull request Jan 28, 2018

New Site: Code Blocks #1531

Closed

5 tasks

ajaymathur and others added 8 commits January 28, 2018 10:13

added styles for user (#1529)

20f2516

* added styles for user * added browser hack for transform

Docusaurus repl (#1533)

6dbaced

* Add repl to new site * Tweak styles * Remove old things * height: 100% fallback

style(code-blocks): bring back Babel style code block (#1532)

af5b5fe

fix users key prop, fix gitignore

dbd8693

Add link to old site, redirect env (#1537)

22273b7

move main contents into an 'about' page, cleanup main page

93136b3

Amathur/user follow up (#1539)

587b885

* removed maincontainer from css style where it could be removed for users page * updated styles?

hzoo changed the title ~~Docusaurus (WIP)~~ Initial Docusaurus rewrite Jan 30, 2018

hzoo merged commit 2f4e200 into master Jan 30, 2018

This was referenced Jan 30, 2018

New Site: Todos #1544

Closed

Gulp setup is out-of-date #1547

Closed

hzoo deleted the docusaurus branch February 3, 2018 14:19

Uh oh!

Uh oh!

Conversation

hzoo commented Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Shouldn't look at the diff since there's too many files changed, looking for more PRs against it

priority/easy

special pages

Uh oh!

babel-bot commented Jan 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtuc commented Jan 25, 2018

Uh oh!

hzoo commented Jan 25, 2018

Uh oh!

JoelMarcey commented Jan 25, 2018

Uh oh!

Daniel15 left a comment

Choose a reason for hiding this comment

Uh oh!

Daniel15 Jan 25, 2018

Choose a reason for hiding this comment

Uh oh!

hzoo commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel15 commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hzoo commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hzoo commented Jan 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GregBorrelly commented Jan 26, 2018

Uh oh!

SavePointSam commented Jan 26, 2018

Uh oh!

hzoo commented Jan 26, 2018

Uh oh!

hzoo commented Jan 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

hzoo commented Jan 24, 2018 •

edited

Loading

babel-bot commented Jan 24, 2018 •

edited

Loading

hzoo commented Jan 25, 2018 •

edited

Loading

Daniel15 commented Jan 25, 2018 •

edited

Loading

hzoo commented Jan 25, 2018 •

edited

Loading

hzoo commented Jan 25, 2018 •

edited

Loading