feat(tools): complete setup page - #1541
Conversation
|
Deploy preview for babel ready! Built with commit 0b8744f |
|
Cool! can also remove https://github.com/babel/website/blob/docusaurus/_data/tools.yml later |
|
@hzoo There are still some bugs to be changed and later changes |
xtuc
changed the title
| <a | ||
| key={j} | ||
| href={`#${tool}`} | ||
| className={isActive ? "tools-button active" : "tools-button"} |
There was a problem hiding this comment.
You should add button class here too to get the buttons to match the others (no yellow background, etc)
|
Ok I merged |
|
@hzoo I complete, but it can't be previewed. |
|
Awesome! nice work on moving over everything - using jquery is ok given we probably want to redo how this works later anyways but this will bring us back to what we had |
| <h2> | ||
| <span className="step-no">4</span> Create <code>.babelrc</code> configuration file | ||
| </h2> | ||
| <MarkdownBlock>{setupBabelrc}</MarkdownBlock> |
There was a problem hiding this comment.
I guess we'd want to translate the setup too? Not sure how this will work with https://docusaurus.io/docs/en/translation.html#enabling-translations-on-pages unless we wrap in translate but it's also markdown
There was a problem hiding this comment.
Or maybe we should make individual pages that are translatable and leave this as english?
|
|
||
| $currentItem = $("[data-name=" + name + "]:not(.btn)").show(); | ||
| $currentItem = $("[data-title=" + name + "]:not(.tools-button)").show(); | ||
| console.log($currentItem); |
hzoo
left a comment
hzoo
left a comment
There was a problem hiding this comment.
Nice how you got the click working via js/jquert atm, I guess we can remove that and just use document.querySelector next?
Going to land for now but we should figure out the setup page is going to be translated (or if we should do something else about that) @JoelMarcey
| } | ||
|
|
||
| $(".btn-group .btn").click(function () { | ||
| $(".tools-group .tools-button").click(function () { |
There was a problem hiding this comment.
It should be easy to convert these to non-jquery so we don't have to load it right?
|
I want to submit quickly, the code quality may be worse, follow-up I will optimize it. |
|
yep +1 me too |
Hi @hzoo - Since the setup page is a https://docusaurus.io/docs/en/translation.html#enabling-translations-on-pages Is that what you were asking? |
* feat(tools): complete setup page UI * update(setup): finished * clean(setup): rm old files * remove console.log
5 participants
Edit by hzoo: Ref #1527
Error:
onClickno response