CLI replication create & delete#123
Conversation
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
=======================================
- Coverage 73.4% 72.4% -1.1%
=======================================
Files 19 22 +3
Lines 1889 2000 +111
=======================================
+ Hits 1387 1448 +61
- Misses 396 438 +42
- Partials 106 114 +8
|
e12c8c4 to
cb6b925
Compare
|
/retitle CLI replication create & delete |
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
cb6b925 to
56d0eab
Compare
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
56d0eab to
9b3b611
Compare
|
/cc @v-harihar |
|
@JohnStrunk , This PR provides the skeleton for replication CLI and not the complete implemenation. Am I right ? |
|
Just create and delete. There are 2 others: set source/destination, and one that has schedule/sync. It's the last of those that actually apply objects to the cluster. |
Makes sense. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnStrunk, v-harihar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There are few minor comments like moving the imports and struct member names. But those can be taken care/corrected in full implementation of replication cmds. |
Describe what this PR does
Adds the
createanddeletecommands to thekubectl-volsync replicationsub-commandIs there anything that requires special attention?
Related issues: