Skip to content

CLI replication create & delete#123

Merged
openshift-merge-robot merged 5 commits into
backube:mainfrom
JohnStrunk:replication-create-delete
Feb 3, 2022
Merged

CLI replication create & delete#123
openshift-merge-robot merged 5 commits into
backube:mainfrom
JohnStrunk:replication-create-delete

Conversation

@JohnStrunk

Copy link
Copy Markdown
Member

Describe what this PR does
Adds the create and delete commands to the kubectl-volsync replication sub-command

Is there anything that requires special attention?

Related issues:

@codecov

codecov Bot commented Jan 12, 2022

Copy link
Copy Markdown

Codecov Report

Merging #123 (9b3b611) into main (f84d09f) will decrease coverage by 1.0%.
The diff coverage is 48.6%.

@@           Coverage Diff           @@
##            main    #123     +/-   ##
=======================================
- Coverage   73.4%   72.4%   -1.1%     
=======================================
  Files         19      22      +3     
  Lines       1889    2000    +111     
=======================================
+ Hits        1387    1448     +61     
- Misses       396     438     +42     
- Partials     106     114      +8     
Impacted Files Coverage Δ
kubectl-volsync/cmd/replication_delete.go 5.0% <5.0%> (ø)
kubectl-volsync/cmd/replication_create.go 8.3% <8.3%> (ø)
kubectl-volsync/cmd/replication.go 63.5% <63.5%> (ø)
kubectl-volsync/cmd/relationship.go 75.6% <100.0%> (+9.0%) ⬆️
controllers/mover/restic/mover.go 79.6% <0.0%> (+0.8%) ⬆️

@JohnStrunk
JohnStrunk force-pushed the replication-create-delete branch 4 times, most recently from e12c8c4 to cb6b925 Compare January 31, 2022 21:30
@JohnStrunk

Copy link
Copy Markdown
Member Author

/retitle CLI replication create & delete

@openshift-ci openshift-ci Bot changed the title [WIP] CLI replication create & delete CLI replication create & delete Feb 1, 2022
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
@JohnStrunk
JohnStrunk force-pushed the replication-create-delete branch from cb6b925 to 56d0eab Compare February 1, 2022 16:00
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
Signed-off-by: John Strunk <jstrunk@redhat.com>
@JohnStrunk
JohnStrunk force-pushed the replication-create-delete branch from 56d0eab to 9b3b611 Compare February 2, 2022 21:38
@JohnStrunk

Copy link
Copy Markdown
Member Author

/cc @v-harihar

@openshift-ci
openshift-ci Bot requested a review from vh05 February 2, 2022 22:21
@vh05

vh05 commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

@JohnStrunk , This PR provides the skeleton for replication CLI and not the complete implemenation. Am I right ?

@JohnStrunk

Copy link
Copy Markdown
Member Author

Just create and delete. There are 2 others: set source/destination, and one that has schedule/sync. It's the last of those that actually apply objects to the cluster.

@vh05

vh05 commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Just create and delete. There are 2 others: set source/destination, and one that has schedule/sync. It's the last of those that actually apply objects to the cluster.

Makes sense.

@vh05 vh05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci

openshift-ci Bot commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, v-harihar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Feb 3, 2022
@vh05

vh05 commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

There are few minor comments like moving the imports and struct member names. But those can be taken care/corrected in full implementation of replication cmds.

@openshift-merge-robot
openshift-merge-robot merged commit 3c0cd6a into backube:main Feb 3, 2022
@JohnStrunk
JohnStrunk deleted the replication-create-delete branch February 14, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants