Skip to content

CLI replication set-source & set-destination#126

Merged
openshift-merge-robot merged 1 commit into
backube:mainfrom
JohnStrunk:replication-src-dst
Feb 22, 2022
Merged

CLI replication set-source & set-destination#126
openshift-merge-robot merged 1 commit into
backube:mainfrom
JohnStrunk:replication-src-dst

Conversation

@JohnStrunk

Copy link
Copy Markdown
Member

Describe what this PR does
Adds the volsync replication { set-source | set-destination } pair of commands to configure the source and destination of rsync-based async replication.

Is there anything that requires special attention?

Related issues:
Depends on #123

@openshift-ci

openshift-ci Bot commented Jan 14, 2022

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnStrunk

Copy link
Copy Markdown
Member Author

/hold
until #123 is merged

@JohnStrunk
JohnStrunk force-pushed the replication-src-dst branch 2 times, most recently from 51e1e9d to 1439f60 Compare January 31, 2022 21:31
@codecov

codecov Bot commented Jan 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #126 (537fbf0) into main (2a78c57) will decrease coverage by 2.9%.
The diff coverage is 29.5%.

@@           Coverage Diff           @@
##            main    #126     +/-   ##
=======================================
- Coverage   69.5%   66.5%   -3.0%     
=======================================
  Files         22      25      +3     
  Lines       2136    2302    +166     
=======================================
+ Hits        1485    1533     +48     
- Misses       535     649    +114     
- Partials     116     120      +4     
Impacted Files Coverage Δ
kubectl-volsync/cmd/replication_setSource.go 15.6% <15.6%> (ø)
kubectl-volsync/cmd/replication_setDestination.go 17.3% <17.3%> (ø)
kubectl-volsync/cmd/parse.go 81.8% <81.8%> (ø)
controllers/mover/rsync/mover.go 77.8% <0.0%> (-1.4%) ⬇️
controllers/mover/restic/mover.go 79.6% <0.0%> (+0.8%) ⬆️

@openshift-ci openshift-ci Bot added size/XXL and removed size/XL labels Feb 3, 2022
Signed-off-by: John Strunk <jstrunk@redhat.com>
@openshift-ci openshift-ci Bot added size/XL and removed size/XXL labels Feb 14, 2022
@JohnStrunk JohnStrunk changed the title [WIP] CLI replication set-source & set-destination CLI replication set-source & set-destination Feb 14, 2022
@JohnStrunk

Copy link
Copy Markdown
Member Author

/unhold
/cc @v-harihar

@vh05

vh05 commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 22, 2022
@openshift-merge-robot
openshift-merge-robot merged commit 5fcc396 into backube:main Feb 22, 2022
@JohnStrunk
JohnStrunk deleted the replication-src-dst branch February 24, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants