Improved ci - #614
Conversation
c257bef to
d8856cb
Compare
There was a problem hiding this comment.
Out of curiosity, could you detail what that does?
There was a problem hiding this comment.
Travis new infrastructure is running on a container infrastructure.
Synce we need a C++ compiler, to build native module, we need to install it. (with the needed libraries for canvas)
|
Thanks for contributing! Could you squash the commits into a single one, as the whole change is fairly small? |
|
about squashing, I don't recommend it. -> that helps identifying falling part of the CI build, and attach change to reason. (for future ci modification if needed) |
What I need commits to be are to help me when I inevitably have to do some archaeological exploration or bisect. Having a single PR (which should correspond to solving a single issue) include multiple commits involved in solving the same piece of the puzzle makes it difficult to see how they relate. Typically, here, AdrieanKhisbeArchives@c8e083b and AdrieanKhisbeArchives@d3e06b3. I could go through the work of explaining exactly which commits should be squashed together, but it would take a long time. For a PR this simple, a single commit is really not an issue.
Every commit should make the build pass. Otherwise, git bisect won't work. |
|
Thanks to this, and the context from the discussion, most of these changes have been merged. Containers were added in #768. PRs are flowing, so please free to open a new PR if there are additional bits worth adding. Closing. |
Improved continous integration with travis container and coverage.
Update dependencies and add New badges to README.
🎁