Skip to content

Improved ci - #614

Closed
AdrieanKhisbe wants to merge 11 commits into
badges:masterfrom
AdrieanKhisbeArchives:improved-ci
Closed

Improved ci#614
AdrieanKhisbe wants to merge 11 commits into
badges:masterfrom
AdrieanKhisbeArchives:improved-ci

Conversation

@AdrieanKhisbe

Copy link
Copy Markdown
Contributor

Improved continous integration with travis container and coverage.

Update dependencies and add New badges to README.

🎁

Comment thread .travis.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, could you detail what that does?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis new infrastructure is running on a container infrastructure.
Synce we need a C++ compiler, to build native module, we need to install it. (with the needed libraries for canvas)

@espadrine

Copy link
Copy Markdown
Member

Thanks for contributing!

Could you squash the commits into a single one, as the whole change is fairly small?

@AdrieanKhisbe

Copy link
Copy Markdown
Contributor Author

about squashing, I don't recommend it. -> that helps identifying falling part of the CI build, and attach change to reason. (for future ci modification if needed)
But it's your call (confirm or not along with the other questions), and I'll do. 😃

@AdrieanKhisbe AdrieanKhisbe added the developer-experience Dev tooling, test framework, and CI label Jan 27, 2016
@espadrine

Copy link
Copy Markdown
Member

about squashing, I don't recommend it

What I need commits to be are to help me when I inevitably have to do some archaeological exploration or bisect. Having a single PR (which should correspond to solving a single issue) include multiple commits involved in solving the same piece of the puzzle makes it difficult to see how they relate. Typically, here, AdrieanKhisbeArchives@c8e083b and AdrieanKhisbeArchives@d3e06b3. I could go through the work of explaining exactly which commits should be squashed together, but it would take a long time. For a PR this simple, a single commit is really not an issue.

that helps identifying falling part of the CI build

Every commit should make the build pass. Otherwise, git bisect won't work.

@paulmelnikow

Copy link
Copy Markdown
Member

Thanks to this, and the context from the discussion, most of these changes have been merged. Containers were added in #768. PRs are flowing, so please free to open a new PR if there are additional bits worth adding. Closing.

@AdrieanKhisbe
AdrieanKhisbe deleted the improved-ci branch April 13, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-experience Dev tooling, test framework, and CI

Development

Successfully merging this pull request may close these issues.

3 participants