Migrate to the new container based infra on Travis-ci - #768
Closed
PeterDaveHello wants to merge 1 commit into
Closed
Migrate to the new container based infra on Travis-ci#768PeterDaveHello wants to merge 1 commit into
PeterDaveHello wants to merge 1 commit into
Conversation
Use the "apt" add-on to install apt packages instead of using "apt-get" command directly, and then move to the new container-based infrastructure, which can speed up the build process. PS: package "g++" removed from the list since it's already the dependency of package "build-essential", no need to duplicate it. Reference: - https://docs.travis-ci.com/user/ci-environment/ - https://docs.travis-ci.com/user/installing-dependencies/ - https://github.com/travis-ci/apt-package-whitelist/
Contributor
Author
|
Hello @espadrine, do I need to do something more to make this acceptable? Thanks. |
This was referenced Oct 10, 2016
paulmelnikow
approved these changes
Mar 20, 2017
Member
|
@espadrine This looks good to me. Would you like to give it a second set of eyes? |
paulmelnikow
added
the
operations
Member
|
Huh. I am surprised the tests pass on Travis CI. I believe we no longer need those packages, but we do need the imagemagick package, which isn't included. |
Member
|
At any rate, no reason to not merge this. I merged it as 2e4721e. |
Member
|
Thanks @espadrine + @PeterDaveHello. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the "apt" add-on to install apt packages instead of using "apt-get"
command directly, and then move to the new container-based
infrastructure, which can speed up the build process.
PS: package "g++" removed from the list since it's already the
dependency of package "build-essential", no need to duplicate it.
Reference: