Add CDNJS version integration - #805
Merged
Merged
Conversation
danielkcz
approved these changes
Oct 10, 2016
Contributor
Author
|
@FredyC thanks for your review 👍 |
Contributor
Author
espadrine
requested changes
Oct 15, 2016
espadrine
left a comment
espadrine
left a comment
Member
There was a problem hiding this comment.
Thanks a lot! The code looks good.
| var library = encodeURIComponent(match[1]); // eg, "express" or "@user/express" | ||
| var format = match[2]; | ||
| var apiUrl = 'https://api.cdnjs.com/libraries/' + library + '?fields=version'; | ||
| var badgeData = getBadgeData('CDNJS', data); |
Member
There was a problem hiding this comment.
Could you put cndjs in lowercase please? The left-hand side is usually all-lowercase.
Contributor
Author
There was a problem hiding this comment.
Updated! BTW, is it possible to add link to the generated markdown code by default? Like to link to the library on CDNJS, thanks.
Member
There was a problem hiding this comment.
Certainly. You simply need to put a data-link="…" to try.html's th for the corresponding badge.
You can do that in a new patch. I will merge this one.
Contributor
Author
There was a problem hiding this comment.
PeterDaveHello
force-pushed
the
cdnjs-badge
branch
from
October 15, 2016 15:16
e1194d3 to
251c792
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To show the latest(and usually the stable) version on CDNJS via CDNJS api.
cc cdnjs/cdnjs#5060