Fix vertex attribute robustness#3706
Merged
baldurk merged 2 commits intobaldurk:v1.xfrom Sep 30, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when replaying Vulkan applications using vertex attribute robustness. For draw calls that rely on vertex attribute robustness, vk_postvs will generate SPIR-V which attempts to read from SSBOs that are not bound which will cause the device to be lost. To fix this, when a vertex input variable that does not have corresponding vertex attribute is detected, a constant value of (0,0,0,0) or (0,0,0,1) is loaded instead. I have also added support for VK_EXT_vertex_attribute_robustness.