Use UTF-8 encoding in shader viewer to fix character corruption#3768
Merged
baldurk merged 1 commit intobaldurk:v1.xfrom Jan 19, 2026
Merged
Use UTF-8 encoding in shader viewer to fix character corruption#3768baldurk merged 1 commit intobaldurk:v1.xfrom
baldurk merged 1 commit intobaldurk:v1.xfrom
Conversation
Owner
|
Thanks for this change, it looks good and I honestly didn't realise scintilla didn't default to UTF-8 since that's what everyone should be using really. As a general note for the future - please try to avoid creating so many PRs at once. It's better to create them as you make changes, to more evenly spread the review burden. We'll look over the PRs over the next while not all at once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures the shader viewer uses UTF-8 encoding when loading source files, preventing character corruption (e.g., in comments) for non-ASCII characters.
The current UTF-8 text displays as unreadable characters, but displays normally after modification.