Skip to content

Comments

Use UTF-8 encoding in shader viewer to fix character corruption#3768

Merged
baldurk merged 1 commit intobaldurk:v1.xfrom
qwmnerbvqwmn:pr/shader-viewer-utf8
Jan 19, 2026
Merged

Use UTF-8 encoding in shader viewer to fix character corruption#3768
baldurk merged 1 commit intobaldurk:v1.xfrom
qwmnerbvqwmn:pr/shader-viewer-utf8

Conversation

@qwmnerbvqwmn
Copy link

Description

Ensures the shader viewer uses UTF-8 encoding when loading source files, preventing character corruption (e.g., in comments) for non-ASCII characters.

The current UTF-8 text displays as unreadable characters, but displays normally after modification.

image image

@baldurk
Copy link
Owner

baldurk commented Jan 19, 2026

Thanks for this change, it looks good and I honestly didn't realise scintilla didn't default to UTF-8 since that's what everyone should be using really.

As a general note for the future - please try to avoid creating so many PRs at once. It's better to create them as you make changes, to more evenly spread the review burden. We'll look over the PRs over the next while not all at once.

@baldurk baldurk merged commit d32454e into baldurk:v1.x Jan 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants