feat(fork): select Base upgrade via BASE_UPGRADE env - #215
Merged
Conversation
The fork harness hardcoded a bare `--base`, always registering base-anvil's default upgrade. Read an optional BASE_UPGRADE env var and forward it as `--base <upgrade>` so a single current base-anvil revision can be tested against each frozen historical suite. Unset preserves today's behavior. Co-Authored-By: Claude <noreply@anthropic.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
September 2, 2026 19:05
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The fork-test harness (
script/fork/__main__.py) hardcoded a bare--basewhenlaunching anvil, so it always registered anvil's default upgrade. This adds
an optional
BASE_UPGRADEenv var that, when set, is forwarded as--base <upgrade>(e.g.--base beryl).Unset/empty preserves today's behavior (bare
--base→ default upgrade), soexisting callers are unaffected.
Why
anvil's
--baseflag can now pin a specific historical upgrade at runtime. Thatlets a single current base-anvil revision test the latest precompile
implementation against each frozen historical base-std suite, instead of pinning
a distinct anvil revision per hardfork. This harness change is what actually
selects the upgrade at launch; CI passes the fork to test via
BASE_UPGRADE.Changes
script/fork/__main__.py: readBASE_UPGRADE, thread it intoanvil_running(...), build the--base [<upgrade>]argv conditionally, andlog the selected upgrade.
script/fork/README.md: documentBASE_UPGRADEin the Environment table.How to test
Requires patched anvil/forge built from a base-anvil revision that supports
--base <upgrade>:[run-fork-tests] base upgrade: berylappears and anvil boots.BASE_UPGRADE=cobaltand with it unset (unset → default, unchanged).environment error — confirming the value is actually forwarded.