fix(fork): support single base-anvil rev for multi-hardfork fork tests (Beryl backport) - #216
Closed
rayyan224 wants to merge 2 commits into
Closed
fix(fork): support single base-anvil rev for multi-hardfork fork tests (Beryl backport)#216rayyan224 wants to merge 2 commits into
rayyan224 wants to merge 2 commits into
Conversation
The fork harness hardcoded a bare `--base`, always registering base-anvil's default upgrade. Read an optional BASE_UPGRADE env var and forward it as `--base <upgrade>` so a single current base-anvil revision can be tested against each frozen historical suite. Unset preserves today's behavior. Co-authored-by: Claude <noreply@anthropic.com>
The new base-anvil's default upgrade is Cobalt, so `base = true` in the fork profile resolves to Cobalt — forge's local precompile dispatcher ran V2 even when the test suite targeted Beryl behavior. Pinning to "beryl" makes forge install V1 dispatch, matching the frozen test expectations in the v1.0.0 snapshot. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
rayyan224
requested review from
amiecorso,
eric-ships,
ilikesymmetry and
stevieraykatz
as code owners
September 3, 2026 14:41
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.54% | 97.67% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.07% | 97.52% | 98.16% | 97.00% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
Collaborator
Author
|
Closing — this PR incorrectly targets main from a v1.0.0-based branch. Reopening as cherry-picks onto main. |
dancaobangthichdanhnhau-boop
left a comment
dancaobangthichdanhnhau-boop
left a comment
There was a problem hiding this comment.
beryl-harness-patch
| int_types = "long" | ||
|
|
||
| [lint] | ||
| ignore = ["test/unit/**/*.sol", "test/regression/**/*.sol", "test/lib/*.sol"] |
There was a problem hiding this comment.
beryl-harness-patch
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks two changes onto
v1.0.0to let the frozen Beryl test suite run correctly against the new shared base-anvil revision (98e7839c) used in base/base BOP-585.Changes:
d5c88cbfeat(fork): select Base upgrade via BASE_UPGRADE env— harness readsBASE_UPGRADEenv var and forwards--base <upgrade>to anvil, so one base-anvil binary can be tested against each frozen historical suite. Cherry-picked from4571b325(PR feat(fork): select Base upgrade via BASE_UPGRADE env #215).66008b9fix(fork): pin fork profile to base = "beryl" for Beryl harness— changesbase = true→base = "beryl"infoundry.toml's[profile.fork]. The new base-anvil'sDEFAULT_BASE_UPGRADEis Cobalt, sobase = truewas silently running forge's local precompile dispatcher at V2 (Cobalt) instead of V1 (Beryl), causing 14 test failures in the v1.0.0 suite.Test plan
98e7839c+--base berylvia base/base PR #4865script/fork/__main__.py,script/fork/README.md, andfoundry.toml🤖 Generated with Claude Code