Fix generate spec to actually test for overwriting #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bashly.yml that the spec uses does not define a "cli-get" command, so if the generator *were* overwriting this file the spec would not catch it. Change the spec to use a command name that the example yml does have, so that it would be overwritten if this happens.
Member
|
You are absolutely right, nice catch! And thanks for the separate PR. I have merged this one into #112 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bashly.yml that the spec uses does not define a "cli-get" command, so if the generator were overwriting this file the spec would not catch it. Change the spec to use a command name that the example yml does have, so that it would be overwritten if this happens.