Fix and merge #109, #110 and #111 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bashly.yml that the spec uses does not define a "cli-get" command, so if the generator *were* overwriting this file the spec would not catch it. Change the spec to use a command name that the example yml does have, so that it would be overwritten if this happens.
This was referenced Sep 30, 2021
Member
Author
|
I am ready to merge. Do you wish to try it before I merge and release? |
DannyBen
changed the title
bashly generate --init
Collaborator
|
Yes, I'm about to go to bed but I will take a closer look tomorrow after work. One quick comment:
The notice about newly created files was useful, even when I wanted otherwise silent output. I'd also be fine without it but that was my reasoning for excluding it in my PR. |
Collaborator
|
Just tried this, LGTM (aside from my note about quieting the create messages, which as I say I don't feel too strongly about). |
Member
Author
|
Ok, I will merge then. About the create messages, I don't see a way around it. Quiet should be quiet. If someone is using it, they have a reason to avoid polluting the stdout, so if we pollute it even with a single character, it will be annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colsolesince the latest Runfile 0.12.0 no longer brings it - closessayis not defined in Runfile #111say <something> unless args['--quiet']toquiet_say <something>bashly generate --quietoutput completely quiet (even created files).bashly generate --quiet#109 - merged in