forked from eproxus/meck
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #3
Open
kesslerm
wants to merge
78
commits into
basho:master
Choose a base branch
from
kesslerm:fix/merge-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Erlang 17.0 to the test matrix
…g the execution of tests when using erlang.mk and meck as a test dependency.
…m.make.all Removed test and doc from target all in Makefile
Fix variable exported from case
Full version: rebar 2.5.1 R15B03 20141014_122343 git 2.5.1-19-g9c7dae7
This prevents warnings about unknown functions in the erlang module.
Allow hiding 'on_load' attribute.
Running tests was removed from make target all in eproxus@30a116a7
Run tests in travis
Meck used to have 'namespaced_dict' while Hamcrest recently introduced a similar macro, 'namespaced_types' for the same purpose. In OTP 18.0 the affected non-namespaced types were completely removed and using them results in a compile error instead of deprecation wagning in 17. So hamcrest.hrl relies on the precense of 'namespaced_types' macro to use the right type. Meck's test module meck_tests.erl includes this header so the 'namespaced_types' macro also have to be defined in meck's test.config. To eliminate duplication I chose to unite the above two macros and use the more generic 'namespaced_types' name.
In order to avoid creating temporary files meck_cover needs direct access to some unexported functions of cover. In OTP 18.0 the internal API of cover changed a bit and compile_beam/2 (which allows passing a binary instead just a filename) was replaced by compile_beams/1. See erlang/otp@ab435488
Update for OTP 18.0
Filter out optional_callbacks attributes
'Problematic modules' list now includes global
Update 'problematic modules list'
The expectations are merged for the function/arity instead of replacing the existing one
Add merge_expects option
This includes cover, which Meck assumes exists on the path.
This will avoid dependencies on the macro for newer Erlang versions, and only use it for legacy compilations
Why is there no list of supported Erlang versions on Travis?!
Fix eunit compile failure on Erlang 17+ (hamcrest)
Thanks for doing this @kesslerm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the basho fork drifting too far from upstream project.
Upstream has important OTP-17+ compatibility fixes.