Skip to content

Conversation

@comius
Copy link
Collaborator

@comius comius commented Nov 4, 2022

Adding MODULE.bazel into the release archive, fixing url to point to actual release url.

@comius comius requested review from a team, c-mita, cushon, katre, lberki and oquenchil as code owners November 4, 2022 15:45
@comius comius requested review from meteorcloudy and removed request for a team, c-mita, cushon, katre, lberki and oquenchil November 4, 2022 15:45
@comius comius changed the title Add MODULE file to the release. Fix problems with release and bump version to 5.3.3 Nov 6, 2022
@copybara-service copybara-service bot merged commit b392c46 into bazelbuild:master Nov 7, 2022
"AUTHORS",
"BUILD",
"LICENSE",
"MODULE.bazel",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meteorcloudy Should I also add WORKSPACE and WORKSPACE.bzlmod to the release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not needed when your project is used as a dependency, so probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants