Skip to content

Fix problems with release and bump version to 5.3.3 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Fix problems with release and bump version to 5.3.3 #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c576d2c
Add MODULE file to the release.
comius Nov 4, 2022
3d36f1d
Version bump and release fixes
comius Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bcr/source.template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"integrity": "",
"strip_prefix": "{REPO}-{VERSION}",
"url": "https://github.com/{OWNER}/{REPO}/archive/refs/tags/{TAG}.tar.gz"
"url": "https://github.com/{OWNER}/{REPO}/releases/download/{TAG}/rules_java-{TAG}.tar.gz"
}
1 change: 1 addition & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ filegroup(
"AUTHORS",
"BUILD",
"LICENSE",
"MODULE.bazel",
Copy link
Collaborator Author

@comius comius Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meteorcloudy Should I also add WORKSPACE and WORKSPACE.bzlmod to the release?

Copy link
Member

@meteorcloudy meteorcloudy Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not needed when your project is used as a dependency, so probably not.

"//java:srcs",
"//toolchains:srcs",
],
Expand Down
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module(
name = "rules_java",
compatibility_level = 1,
version = "5.3.2",
version = "5.3.3",
)

bazel_dep(name = "platforms", version = "0.0.4")
Expand Down
2 changes: 1 addition & 1 deletion java/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ load("//java/private:native.bzl", "NativeJavaInfo", "NativeJavaPluginInfo", "nat
# Do not touch: This line marks the end of loads; needed for PR importing.

_MIGRATION_TAG = "__JAVA_RULES_MIGRATION_DO_NOT_USE_WILL_BREAK__"
version = "5.3.2"
version = "5.3.3"

def _add_tags(attrs):
if "tags" in attrs and attrs["tags"] != None:
Expand Down