Bump sendspin-cpp to v0.6.1 - #104
Merged
Merged
Conversation
Brings per-connection hello retries (v0.5.0 had a single shared retry slot — two connections arriving within the 100ms hello window left one permanently ungreeted), the pre-hello send gate, and the 32-bit frames_to_microseconds overflow fix relevant on armv6 targets. Patches 0002/0003 regenerated against the new tree (connection is now make_shared per upstream's session-ownership rework); 0001 applies unchanged. Also corrects the README bump procedure: the whole per-target build dir must be removed, not just _deps, or the cached SENDSPIN_CPP_REF silently repopulates the old pin. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the sendspin_player’s pinned sendspin-cpp dependency to v0.6.1 (via a commit SHA) and refreshes the local patch-chain + documentation so the bump remains reproducible and reviewable within the existing FetchContent + marker-check workflow.
Changes:
- Bump
SENDSPIN_CPP_REFfrom the v0.5.0-resolved SHA to the v0.6.1-resolved SHA. - Regenerate/update patch-chain details to match upstream’s connection ownership changes (
make_unique→make_shared) and update marker checks accordingly. - Update the bump procedure docs to account for CMake cache behavior by removing the full per-target
sendspin_playerbuild dir.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| c_src/sendspin_player/CMakeLists.txt | Updates the pinned sendspin-cpp SHA to v0.6.1 and adjusts patch marker expectations for the regenerated patches. |
| c_src/sendspin_player/README.md | Updates the documented pinned SHA/version and corrects the bump procedure to account for CMake cache persistence. |
| c_src/sendspin_player/patches/0002-defer-registration-until-open.patch | Regenerated patch content to align with upstream’s session/connection ownership changes (shared ownership). |
| c_src/sendspin_player/patches/0003-listener-bound-hook.patch | Regenerated patch header context for the listener-bound hook against the new upstream tree. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The repo pin now always wins over a stale CMakeCache.txt, matching the file's other CACHE settings; command-line overrides go through FETCHCONTENT_SOURCE_DIR_SENDSPIN-CPP instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the sendspin-cpp pin from v0.5.0 (
573efd5) to v0.6.1 (ef1157f), following the README's release-blocking review procedure.What the bump delivers
hello_retry_slot, so two connections arriving within the 100 ms hello window left one permanently ungreeted. Validated: two probes 30 ms apart now both receiveclient/hello(one stayed silent on v0.5.0).frames_to_microsecondsoverflow fix (Bluetooth web tab, event-driven hotplug, and quieter device logging #58) — relevant on our armv6/armv7 targets.Patch chain
0001-configurable-ws-portapplies unchanged.0002-defer-registration-until-openand0003-listener-bound-hookregenerated against the new tree (upstream's session-ownership rework switched the server connection tomake_shared); the 0002 marker check updated accordingly. All three verified to apply cleanly to pristine v0.6.1.SENDSPIN_CPP_REFis a CMakeCACHEvariable, so a survivingCMakeCache.txtsilently repopulates the old pin (bit me during this bump; the patch chain failed loudly against the wrong tree, exactly as the marker checks intend).Validation (per README bump procedure)
started → volume → static_delay → listening, contract suite 10 passedlisteningstill deferred until our own listener bindsNot HW-validated on the Pi yet; the known residual (established-but-silent peers, no upstream handshake deadline) is unchanged and still documented in the README.
🤖 Generated with Claude Code