Skip to content

Answer the project-files FIXME with a measurement #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbatsov merged 1 commit into from
Jul 29, 2026
Merged

Answer the project-files FIXME with a measurement #2143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion projectile.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15837,7 +15837,13 @@ when opening new files. PROJECT-ROOT defaults to the current project."
;; see https://github.com/bbatsov/projectile/issues/1591#issuecomment-896423965
;; That's needed because Projectile uses relative paths for project files
;; and project.el expects them to be absolute.
;; FIXME: That's probably going to be very slow in large projects.
;;
;; Measured rather than feared: this is 4 ms for 50k files and 20 ms for
;; 200k, a rounding error next to the listing it is prepending to.
;; `expand-file-name' would be the obvious alternative and is 18 times
;; slower, since it consults the filesystem's notion of the default
;; directory; the paths here are already absolute once the root is on
;; the front, so `concat' is both correct and the cheap option.
(mapcar (lambda (f)
(concat root f))
(projectile-project-files root))))
Expand Down
Loading