Let comint mode cover the tasks too - #2157
Merged
Merged
Conversation
`projectile-use-comint-mode' promises an interactive buffer for what Projectile runs, and `t' reads as all of it - but `projectile--run-task' never passed the flag on, so a task always landed in a read-only compilation buffer. The reporter's case is a system rebuild that needs a sudo password: there is nowhere to type it, so the task simply can't be run. Not a regression from folding the six per-command options into one in 3.4 - no per-task option ever existed - but the single option reads like it covers everything, and tasks go through the same runner and the same command history. So they're covered now: `task' can be named in the list, and `t' includes them. `projectile-use-comint-mode-p' also returns a real boolean now. It was handing back whatever `memq' found, so a list-valued option sent its own tail into `compile' as the COMINT argument. Harmless, since only its truthiness was ever read, but it made the new spec assert on `(task)'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2156.
projectile-use-comint-modesays it makes the commands Projectile runs interactive, andtreads as all of them - butprojectile--run-tasknever passed the flag on, so a task always got a read-only compilation buffer. The reporter's case is a system rebuild that wants a sudo password, and there's nowhere to type it.Not a regression from folding the six per-command options into one in 3.4, since no per-task option ever existed. But the single option reads like it covers everything, and tasks go through the same runner and feed the same command history, so they're covered now: name
taskin the list, or sett.While in there,
projectile-use-comint-mode-preturns an actual boolean. It was handing back whatevermemqfound, so a list-valued option sent its own tail down intocompileas the COMINT argument - harmless, since only truthiness was read, but it made the new spec assert on(task).