Image component alignment and placeholder - #10315
Merged
Merged
Conversation
amoore108
approved these changes
Sep 26, 2022
nicola-d-bbc
approved these changes
Sep 26, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Supports #10306
Overall change:
While replacing the old image component with the new one in the
StoryPromocomponent, some minor behaviour differences were observed. These include:sizesattribute with default100vwwas sizing the image in AMP incorrectly when dimensions were not providedThis PR addresses the above issues and updates the README to explain better how the aspect ratio works.
Code changes:
aspectRatioandobjectFit:coverCSS properties100vwsizes value as this contributed to incorrect scalingcross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)